[https://nvbugs/6274934][fix] Skip DeepSeek-V3-Lite dis-agg test on non-Hopper by Shixiaowei02 · Pull Request #15577 · NVIDIA/TensorRT-LLM

Shixiaowei02 · 2026-06-24T06:57:24Z

Summary by CodeRabbit

Tests
- Updated one conditional disaggregation worker test to skip on systems without Hopper support, reducing unsupported test runs and related failures.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Shixiaowei02 · 2026-06-24T06:58:22Z

/bot run --add-multi-gpu-test --disable-fail-fast

coderabbitai · 2026-06-24T06:58:29Z

📝 Walkthrough

Walkthrough

The @skip_no_hopper decorator is added to the test_workers_conditional_disaggregation_deepseek_v3_lite_bf16 test in the disaggregated workers integration test file, gating its execution to environments with Hopper hardware support. No other logic is changed.

Changes

Test Hardware Gate

Layer / File(s)	Summary
Add `@skip`_no_hopper to DeepSeek-V3-Lite bf16 test `tests/integration/defs/disaggregated/test_workers.py`	Adds `@skip_no_hopper` decorator to `test_workers_conditional_disaggregation_deepseek_v3_lite_bf16`, skipping execution on non-Hopper environments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

xinhe-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is still the template placeholder and does not explain the issue, solution, or test coverage.	Add a short Description and Test Coverage section that summarizes the Hopper-only skip and the tests used to validate it.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the change: skipping the DeepSeek-V3-Lite disaggregation test on non-Hopper GPUs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

Shixiaowei02 · 2026-06-25T01:14:31Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2026-06-25T01:23:26Z

PR_Github #55642 [ run ] triggered by Bot. Commit: d3d6119 Link to invocation

tensorrt-cicd · 2026-06-25T01:24:10Z

PR_Github #55642 [ run ] completed with state FAILURE. Commit: d3d6119

Link to invocation

fredricz-20070104

Approved

Shixiaowei02 · 2026-06-30T02:10:38Z

/bot run --add-multi-gpu-test --disable-fail-fast

Shixiaowei02 · 2026-07-01T06:52:45Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2026-07-01T06:58:30Z

PR_Github #56871 [ run ] triggered by Bot. Commit: c56defe Link to invocation

tensorrt-cicd · 2026-07-01T12:33:53Z

PR_Github #56871 [ run ] completed with state SUCCESS. Commit: c56defe
/LLM/main/L0_MergeRequest_PR pipeline #45682 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

…disagg worker test on non-Hopper test_workers_conditional_disaggregation_deepseek_v3_lite_bf16 runs DeepSeek-V3-Lite, which uses MLA. The context-phase MLA FMHA kernels (headSize=192, headSizeV=128) are only available on Hopper (SM90), so on pre-Hopper GPUs AttentionOp::initialize() aborts with "Deepseek should be supported by fmha in context part." Add @skip_no_hopper, matching the sibling DeepSeek-V3-Lite disaggregation tests (test_workers_kv_cache_aware_router_deepseek_v3_lite_bf16 and test_disaggregated_deepseek_v3_lite_bf16_conditional). Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>

Shixiaowei02 · 2026-07-15T11:09:39Z

/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1"

tensorrt-cicd · 2026-07-15T11:14:57Z

PR_Github #59443 [ run ] triggered by Bot. Commit: d554c77 Link to invocation

tensorrt-cicd · 2026-07-15T15:58:50Z

PR_Github #59443 [ run ] completed with state FAILURE. Commit: d554c77
/LLM/main/L0_MergeRequest_PR pipeline #47911 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Shixiaowei02 requested a review from a team as a code owner June 24, 2026 06:57

github-actions Bot assigned Shixiaowei02 Jun 24, 2026

Shixiaowei02 force-pushed the user/xiaoweis/nvbug-6274934-skip-no-hopper branch from e6c42c1 to d3d6119 Compare June 24, 2026 06:57

fredricz-20070104 approved these changes Jun 26, 2026

View reviewed changes

Shixiaowei02 force-pushed the user/xiaoweis/nvbug-6274934-skip-no-hopper branch from d3d6119 to a9454a5 Compare June 30, 2026 02:10

Shixiaowei02 force-pushed the user/xiaoweis/nvbug-6274934-skip-no-hopper branch from a9454a5 to c56defe Compare July 1, 2026 06:52

Shixiaowei02 force-pushed the user/xiaoweis/nvbug-6274934-skip-no-hopper branch from c56defe to d554c77 Compare July 15, 2026 10:53

Shixiaowei02 requested review from a team as code owners July 15, 2026 10:53

Shixiaowei02 requested review from bo-nv, reasonsolo, ruodil and yingguo-trt July 15, 2026 10:53

yingguo-trt approved these changes Jul 16, 2026

View reviewed changes

yufeiwu-nv removed the request for review from ruodil July 16, 2026 06:53

Shixiaowei02 closed this Jul 24, 2026

Uh oh!

Conversation

Shixiaowei02 commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

Shixiaowei02 commented Jun 24, 2026

Uh oh!

coderabbitai Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

Shixiaowei02 commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

tensorrt-cicd commented Jun 25, 2026

Uh oh!

fredricz-20070104 left a comment

Choose a reason for hiding this comment

Uh oh!

Shixiaowei02 commented Jun 30, 2026

Uh oh!

Shixiaowei02 commented Jul 1, 2026

Uh oh!

tensorrt-cicd commented Jul 1, 2026

Uh oh!

tensorrt-cicd commented Jul 1, 2026

Uh oh!

Shixiaowei02 commented Jul 15, 2026

Uh oh!

tensorrt-cicd commented Jul 15, 2026

Uh oh!

tensorrt-cicd commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Shixiaowei02 commented Jun 24, 2026 •

edited

Loading

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading